Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing models to Transformzklend #278

Merged

Conversation

petersdt
Copy link
Contributor

@petersdt petersdt commented Nov 1, 2024

Fixes #275

Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far looks good to me, add missing method to ZkLendDBConnector

@djeck1432
Copy link
Collaborator

@djeck1432 djeck1432 marked this pull request as ready for review November 1, 2024 22:40
@djeck1432
Copy link
Collaborator

@petersdt Please, fix pylint issues

@djeck1432
Copy link
Collaborator

@petersdt Please, fix pylint issue, hackathon is ending

1 similar comment
@djeck1432
Copy link
Collaborator

@petersdt Please, fix pylint issue, hackathon is ending

Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit aa0c887 into CarmineOptions:master Nov 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing models to TransformZklend
2 participants